Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 )
Change subject: IMPALA-5022 part 1/2: Outer join simplification ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/16266/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16266/16//COMMIT_MSG@9 PS16, Line 9: Outer joins in SQL can return rows with certain columns filled with : NULLs when a match can not be found. However, such rows can be : rejected by null-rejecting predicates. The conditions in a null-rejecting : predicate that are always evaluated to FALSE for NULLs are referred to : as null-filtering conditions. : : In general, an outer join can be converted to an inner joi > Maybe reworded as Done http://gerrit.cloudera.org:8080/#/c/16266/16//COMMIT_MSG@50 PS16, Line 50: > I think we need to add a high-level description of what work is done in thi Done -- To view, visit http://gerrit.cloudera.org:8080/16266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7804033fac68e93f33c387dc68ef67f803e93e Gerrit-Change-Number: 16266 Gerrit-PatchSet: 18 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Tue, 01 Sep 2020 13:16:56 +0000 Gerrit-HasComments: Yes