Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16065 )
Change subject: IMPALA-10090 Create aarch64 development evironment on unbuntu 18.04 ...................................................................... Patch Set 14: (6 comments) Thank you for the contribution, this should help a lot with building ubuntu on aarch64. I just had a few small changes I'm requesting. http://gerrit.cloudera.org:8080/#/c/16065/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16065/14//COMMIT_MSG@7 PS14, Line 7: evironment environment http://gerrit.cloudera.org:8080/#/c/16065/14//COMMIT_MSG@7 PS14, Line 7: unbuntu ubuntu http://gerrit.cloudera.org:8080/#/c/16065/13/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/16065/13/bin/bootstrap_system.sh@220 PS13, Line 220: if [[ $ARCH_NAME == 'aarch64' ]]; then Can you comment why these packages are needed on aarch64 but not x86? Is this for building native-toolchain? http://gerrit.cloudera.org:8080/#/c/16065/13/bin/bootstrap_system.sh@480 PS13, Line 480: echo -e "\nexport SKIP_TOOLCHAIN_BOOTSTRAP=true" >> \ We'll need to update this to point to the official native-toolchain repo http://gerrit.cloudera.org:8080/#/c/16065/14/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/16065/14/buildall.sh@404 PS14, Line 404: local builded "locally built" http://gerrit.cloudera.org:8080/#/c/16065/14/buildall.sh@486 PS14, Line 486: # architecture. so here we will let user decide this value. Thanks for the cleanup -- To view, visit http://gerrit.cloudera.org:8080/16065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I769668c834ab0dd504a822ed9153186778275d59 Gerrit-Change-Number: 16065 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 01 Sep 2020 22:51:14 +0000 Gerrit-HasComments: Yes
