Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16382 )
Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function. ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h File be/src/exprs/datasketches-functions.h: http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@37 PS1, Line 37: /// 'serialized_sketch' is expected as a serialized Apache DataSketches HLL sketch. If nit: leave an empty line before starting the comment. http://gerrit.cloudera.org:8080/#/c/16382/1/be/src/exprs/datasketches-functions.h@39 PS1, Line 39: DataSketches sketch DataSketches HLL sketch -- To view, visit http://gerrit.cloudera.org:8080/16382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85dbf20b5114dd75c300eef0accabe90eac240a0 Gerrit-Change-Number: 16382 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Sep 2020 08:44:51 +0000 Gerrit-HasComments: Yes
