Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 )
Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG@23 PS2, Line 23: impala-shell has been modified to dump both the most recent query : attempt and the original query attempt. I think dumping all profiles may break some tools that grep results from the output. However, we can extend the profile command in later patches to support different requirements. http://gerrit.cloudera.org:8080/#/c/16406/2//COMMIT_MSG@27 PS2, Line 27: Beeswax is being : deprecated soon. BTW, is there a timeline or any blockers for this? http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@773 PS2, Line 773: std:: nit: can use string directly http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@784 PS2, Line 784: JSONProfileToStringProfile nit: JsonProfileToStringProfile http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@785 PS2, Line 785: std::stringstream* string_profile, rapidjson::Document* json_profile nit: I think our code style tries to put the input vars before the output vars, so we should put 'json_profile' the first arg here. Also use const reference for inputs. So it's void JsonProfileToStringProfile(const rapidjson::Document& json_profile, std::stringstream* string_profile) https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs http://gerrit.cloudera.org:8080/#/c/16406/2/be/src/service/impala-server.h@787 PS2, Line 787: void SetProfile(RuntimeProfileOutput* profile, TGetRuntimeProfileResp& return_val, Could you add a method comment for this? Also move the 'request' to be the first arg? http://gerrit.cloudera.org:8080/#/c/16406/2/tests/custom_cluster/test_shell_interactive.py File tests/custom_cluster/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16406/2/tests/custom_cluster/test_shell_interactive.py@71 PS2, Line 71: vector, ['-q', query_options + query + "; profile", '-B'])) Also test about the -p or --show_profiles option? -- To view, visit http://gerrit.cloudera.org:8080/16406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89cee02947b311e7bf9c7274f47dfc7214c1bb65 Gerrit-Change-Number: 16406 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Sep 2020 14:25:02 +0000 Gerrit-HasComments: Yes
