Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16439 )
Change subject: IMPALA-9664: [WIP] Insert event improvements ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1116 PS1, Line 1116: * @param insertEventDataList A list of insert event encapsulating the information needed line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4598 PS1, Line 4598: makeInsertEventData((HdfsTable) table, partVals, newFiles, isInsertOverwrite)); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@730 PS1, Line 730: List<NotificationEvent> events = ((SynchronousHMSEventProcessorForTests) eventsProcessor_) line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@762 PS1, Line 762: runInsertTest(tableToInsertPart, tableToInsertMulPart, numberOfSelfEventsBefore, false); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@780 PS1, Line 780: runInsertTest(tableToInsertPart, tableToInsertMulPart, numberOfSelfEventsBefore, true); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16439/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@885 PS1, Line 885: unpartTable.getFileSystem(), new Path(unpartTable.getHdfsBaseDir()), overwrite, "copy_"); line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icaf3fe0adff755ff853960f270ceb45b11a84f0a Gerrit-Change-Number: 16439 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 11 Sep 2020 01:53:34 +0000 Gerrit-HasComments: Yes
