Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 )
Change subject: [WIP] MPALA-10075: Reuse unchanged partition instances ...................................................................... Patch Set 2: (3 comments) Thank Qifan's review! Will add some new tests in the next patch set. http://gerrit.cloudera.org:8080/#/c/16392/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16392/1//COMMIT_MSG@17 PS1, Line 17: Manually > I know it is a WIP but maybe add several tests to automate the testing new Yeah, left a TODO for this below. I plan to expose the partition ids inside catalogd so we can verify whether the partition instances are reused after some DDL/DMLs. http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@76 PS1, Line 76: > Not clear on the abbreviation. Maybe hdfsPartitionChanged_? Sorry, it means fileDescriptorsChanged_. I removed this field in the new patch after fixing a bug. It's simpler to not introduce and maintain a new field. http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/16392/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1548 PS1, Line 1548: hasIncrementalStats_ == oldInstan > I wonder if the following situation qualifies a change. Yes, in this case, files are changed, so file descriptors should be different (filesChanged_ is true). -- To view, visit http://gerrit.cloudera.org:8080/16392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd645c260d271291021e52fdac4b74924df1170 Gerrit-Change-Number: 16392 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 14 Sep 2020 09:47:48 +0000 Gerrit-HasComments: Yes
