Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 )
Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/16369/16/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16369/16/be/src/scheduling/admission-controller.cc@1557 PS16, Line 1557: bool all_blacklisted; > The function NumExecutors() need to go through the map to find the total nu I think a single iteration of the map during the NumExecutors call is fine. the number of executors in a group is expected to be at max a few hundred, which seems trivially small for a 'for loop' http://gerrit.cloudera.org:8080/#/c/16369/16/be/src/scheduling/executor-group.cc File be/src/scheduling/executor-group.cc: http://gerrit.cloudera.org:8080/#/c/16369/16/be/src/scheduling/executor-group.cc@52 PS16, Line 52: if (!blacklisted_executor_found) return nullptr; > I guess that in most cases the executor, which cause first attempt failed, I don't think there is much cost associated with copying an executor group, the size is expected to be relatively small. Generally, I lean towards cleaner code vs. optimizations that are unproven to be needed. -- To view, visit http://gerrit.cloudera.org:8080/16369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00bc1b5026efbd0670ffbe57bcebc457d34cb105 Gerrit-Change-Number: 16369 Gerrit-PatchSet: 16 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Sep 2020 23:38:28 +0000 Gerrit-HasComments: Yes
