Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )
Change subject: IMPALA-9652: CTAS doesn't respect transactional properties ...................................................................... Patch Set 1: Code-Review+2 (3 comments) Thanks for fixing these bugs, I have only nits. http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@9 PS1, Line 9: Because of a bug the INSERT part of a CTAS statement didn't Can you add more info about how we worked before the change, and how we will work after it? E.g. before the change the files written by CTAS were put the the root directory as original files. After the change the files will go to a delta directory like for insert and the table will be locked during the operation. http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@10 PS1, Line 10: transaction Do I understand well that we are still not transactional in a multi table sense? So while the source tables will be locked, no refresh is done on them and the new table can be created based on their state at a previous transaction id. http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test File testdata/workloads/functional-query/queries/QueryTest/acid-insert.test: http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test@65 PS1, Line 65: ==== : ---- QUERY : drop table insertonly_nopart_ctas; Is there a reason why we do the cleanup here? The whole DB is dropped after running the test. -- To view, visit http://gerrit.cloudera.org:8080/16472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77 Gerrit-Change-Number: 16472 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Sep 2020 11:23:37 +0000 Gerrit-HasComments: Yes
