Sahil Takiar has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/16414 )
Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause
occurred
......................................................................
IMPALA-9046: Profile counter that indicates if a JVM pause occurred
Adds a new section to the host profiles that includes JVM GC related
metrics. These metrics are taken from JMX and the JvmPauseMonitor.
The host profiles will now include a section like below:
JVM:
- GcCount: 19
- GcNumInfoThresholdExceeded: 0
- GcNumWarnThresholdExceeded: 0
- GcTimeMillis: 17s476ms
- GcTotalExtraSleepTimeMillis: 380
GcNumInfoThresholdExceeded, GcNumWarnThresholdExceeded, and
GcTotalExtraSleepTimeMillis are all taken from JvmPauseMonitor.
GcCount and GcTimeMillis are taken from JMX (specifically,
GarbageCollectorMXBean).
The counters themselves are derived from the impalad host-level metrics.
Changed the 'lock_' in JvmMetricCache (in memory-metrics.h) from a mutex
to a shared_mutex. Most accessors of the JvmMetricCache member variables
are read-only. A write only occurs lazily at most every second. This
should help reduce lock contention on JvmMetricCache now that all
queries will start accessing info stored by the JvmMetricCache.
Testing:
* Ran core tests
* Added a test that runs Java UDF, which triggers JVM GC
Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b
Reviewed-on: http://gerrit.cloudera.org:8080/16414
Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com>
Reviewed-by: Sahil Takiar <stak...@cloudera.com>
Tested-by: Sahil Takiar <stak...@cloudera.com>
---
M be/src/runtime/query-state.cc
M be/src/util/memory-metrics.cc
M be/src/util/memory-metrics.h
A tests/custom_cluster/test_observability.py
A tests/test-hive-udfs/src/main/java/org/apache/impala/JavaGcUdfTest.java
5 files changed, 223 insertions(+), 24 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Sahil Takiar: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbaae2f9142b8be94532a0a147668a3d96091b0b
Gerrit-Change-Number: 16414
Gerrit-PatchSet: 6
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
