Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16459 )
Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ ...................................................................... IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ This data race can be reproduced by TestCompactCatalogUpdates.test_restart_catalogd, although it does not seem to always occur. The data race was originally reported in a Jenkins job, but I could not reproduce it locally. The fix is to acquire a read lock while reading some UrlHandler objects. I cleaned up some of the other involved variables and made them const. These variables are set during construction time, and never modified afterwards. Testing: * Ran be and custom cluster TSAN tests Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Reviewed-on: http://gerrit.cloudera.org:8080/16459 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/util/webserver.cc M be/src/util/webserver.h 2 files changed, 15 insertions(+), 12 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6923af4754e3fe72b8b04c5303a1e7a79da7613a Gerrit-Change-Number: 16459 Gerrit-PatchSet: 7 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
