Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 )
Change subject: IMPALA-10178 Run-time profile shall report skews ...................................................................... Patch Set 31: (1 comment) http://gerrit.cloudera.org:8080/#/c/16474/31/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/16474/31/be/src/util/runtime-profile.cc@1949 PS31, Line 1949: if (stddev > 5) { > Oh, that is very interesting result. Can you send me the data? If its useful for future work, why not add it later on? Or at least don't expose it in the runtime profile. my concern is that when aggressive mode is enabled, most queries will report skew, and then customers will start complaining asking why their queries are skewed, even though the problem is actually not that serious, or that is just expected behavior. -- To view, visit http://gerrit.cloudera.org:8080/16474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91041f2856eef8293ea78f1721f97469062589a1 Gerrit-Change-Number: 16474 Gerrit-PatchSet: 31 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Oct 2020 18:02:58 +0000 Gerrit-HasComments: Yes
