Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/16516 )
Change subject: IMPALA-10189: don't reload partitions for drop stats ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16516/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16516/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1647 PS8, Line 1647: // Remove the ROW_COUNT parameter if it has been set and set numRows to reflect change "set and set" to "set and update". Maybe better to move the numRows comment down further so it's more clear what code that belongs with. http://gerrit.cloudera.org:8080/#/c/16516/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4765 PS8, Line 4765: FileChecksum checkSum = fs.getFileChecksum(filePath); getFileSystem was changed to return null and is being used unchecked here. -- To view, visit http://gerrit.cloudera.org:8080/16516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91009d6e9fdf25b3a3341fd1d29219519eb39a3d Gerrit-Change-Number: 16516 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 20:52:25 +0000 Gerrit-HasComments: Yes
