Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 )
Change subject: IMPALA-10075: Reuse unchanged partition instances ...................................................................... Patch Set 7: (2 comments) Thank Csaba and Qifan! The new tests in this patch depend on https://gerrit.cloudera.org/c/16449/ which exposes partition ids in JSON. Could you help to review it as well? http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@274 PS6, Line 274: as t > nit: "as" would be better here Done http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@937 PS6, Line 937: a > nit: a Done -- To view, visit http://gerrit.cloudera.org:8080/16392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd645c260d271291021e52fdac4b74924df1170 Gerrit-Change-Number: 16392 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Oct 2020 00:56:54 +0000 Gerrit-HasComments: Yes
