Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 )
Change subject: [WIP] IMPALA-7097 Print EC info in the query plan and profile ...................................................................... Patch Set 1: (4 comments) general approach looks good, would be nice to see a sample of what the new explain plans look like http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@903 PS1, Line 903: (long)1 can be replaced by "1L" http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1503 PS1, Line 1503: Long nit: can just use "long" here and below http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1505 PS1, Line 1505: if ( totalNumECFiles != null && totalECSize!= null ) { nit: unnecessary spacing around the the if condition http://gerrit.cloudera.org:8080/#/c/16587/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1511 PS1, Line 1511: No report : // on EC related info. why not? we want to report EC stats if the data is non-partitioned right? -- To view, visit http://gerrit.cloudera.org:8080/16587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ea378914624a714fde820d290b3b9c43325c6a1 Gerrit-Change-Number: 16587 Gerrit-PatchSet: 1 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Oct 2020 19:15:03 +0000 Gerrit-HasComments: Yes
