wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16575 )
Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling ...................................................................... Patch Set 6: Code-Review+1 (5 comments) Thanks for the quick turnaround, LGTM, just few small nits. http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java: http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@41 PS6, Line 41: org.apache.iceberg.hadoop.HadoopCatalog Better to import this class, and use 'HadoopCatalog' directly, just like 'HadoopTables' in IcebergHadoopTables.java http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@44 PS6, Line 44: org.apache.iceberg.hadoop.HadoopCatalog Same as below. http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java: http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java@29 PS6, Line 29: import org.apache.impala.catalog.iceberg.IcebergCatalog; Unnecessary import. http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java@31 PS6, Line 31: import org.apache.impala.common.ImpalaRuntimeException; Unnecessary import. http://gerrit.cloudera.org:8080/#/c/16575/6/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java@33 PS6, Line 33: import org.apache.impala.util.IcebergUtil; Unnecessary import. -- To view, visit http://gerrit.cloudera.org:8080/16575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie69dff6cd6b8b3dc0ba5f7671b8504a936032a85 Gerrit-Change-Number: 16575 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 14 Oct 2020 01:56:43 +0000 Gerrit-HasComments: Yes
