Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16449 to look at the new patch set (#9). Change subject: IMPALA-10168: Expose JSON catalog objects in catalogd's debug page ...................................................................... IMPALA-10168: Expose JSON catalog objects in catalogd's debug page Catalogd has a debug page at '/catalog_object' showing catalog objects in thrift debug strings. It's inconvenient for tests to parse the thrift string and get interested infos. Catalogd has a debug page at '/catalog_object' showing catalog objects in thrift debug strings. It's inconvenient for tests to parse the thrift string and get interesting infos. This patch extends this page to support returning JSON results, which eases tests to extract complex infos from the catalog objects, e.g. partition ids of a hdfs table. Just like getting json results from other pages, the usage is adding a ‘json’ argument in the URL, e.g. http://localhost:25020/catalog_object?json&object_type=TABLE&object_name=db1.tbl1 Implementation: Csaba helped to find that Thrift has a protocol, TSimpleJSONProtocol, which can convert thrift objects to human readable JSON strings. This simplifies the implementation a lot. However, TSimpleJSONProtocol is not implemented in cpp yet (THRIFT-2476). So we do the conversion in FE to use its java implementation. Tests: - Add tests to verify json fields existence. Change-Id: I15f256b4e3f5206c7140746694106e03b0a4ad92 --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog.cc M be/src/catalog/catalog.h M fe/src/main/java/org/apache/impala/service/JniCatalog.java M tests/webserver/test_web_pages.py 5 files changed, 96 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/16449/9 -- To view, visit http://gerrit.cloudera.org:8080/16449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15f256b4e3f5206c7140746694106e03b0a4ad92 Gerrit-Change-Number: 16449 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>