wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 )
Change subject: IMPALA-10166 ALTER TABLE for Iceberg tables ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16606/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16606/3//COMMIT_MSG@11 PS3, Line 11: * ADD COLUMNS : * DROP COLUMN : * REPLACE COLUMNS : * ALTER COLUMN CHANGE COLUMN > Iceberg assigns a unique field id to each fields to support schema evolutio Thanks Zoltan, it indeed a problem. If you insist supporting for ALTER TABLE statements that don't make the table unreadable to Impala. I will separate this patch to these sub-tasks: 1. Keeping ADD COLUMNS/RENAME/SET TBLPROPERTIES in this patch as part1. Maybe we can also including DROP COLUMN statement. 2. Implement a new option such as ‘ICEBERG_FIELD’ in TParquetFallbackSchemaResolution in another patch as part2, so we can use filed id to resolve columns. 3. After we finished the task2, we can supporting REPLACE/ALTER in a new patch as part3. Maybe we can also merge task2 and task3 into one task. How do you think? -- To view, visit http://gerrit.cloudera.org:8080/16606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5104cc47c7b42dacdb52983f503cd263135d6bfc Gerrit-Change-Number: 16606 Gerrit-PatchSet: 3 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 20 Oct 2020 12:45:59 +0000 Gerrit-HasComments: Yes
