Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16613/2/be/src/scheduling/admission-controller-test.cc File be/src/scheduling/admission-controller-test.cc: http://gerrit.cloudera.org:8080/#/c/16613/2/be/src/scheduling/admission-controller-test.cc@382 PS2, Line 382: CanAdmitRequestMemory > can you add a test where cannot_scale_with_executors is true if not enough There is a test as part of 'Test 2' of DedicatedCoordAdmissionChecks on line 944, do we need more than that? http://gerrit.cloudera.org:8080/#/c/16613/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/16613/2/be/src/scheduling/admission-controller.cc@1785 PS2, Line 1785: Increment > Not sure if it is possible to implement this non-trivially but should we on I understand what you mean these numbers can get quite big. But I am not sure how to do this without some complexity. Do you have a suggestion? http://gerrit.cloudera.org:8080/#/c/16613/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/16613/2/common/thrift/metrics.json@2731 PS2, Line 2731: Query dequeue failed because of a non-scalable limit > nit: just thinking out aloud here: technically it is scalable, and we can p I originally planned to have the name be related to "coordinator" but (elsewhere) Tim Armstrong suggested making it more generic (assuming I understood him correctly). It is true that today it is always a coordinator limit but I suppose it could be something else in future. -- To view, visit http://gerrit.cloudera.org:8080/16613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3456396ac139c562ad9cd3ac1a624d8f35487518 Gerrit-Change-Number: 16613 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 01:13:22 +0000 Gerrit-HasComments: Yes
