Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 )
Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Thanks for your response, LGTM! I'm only giving it +1 to let others take a look as well. http://gerrit.cloudera.org:8080/#/c/16606/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16606/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3388 PS4, Line 3388: .ICEBERG > In fact, I don't quite understand where the problem is. I write this method It was just a nitpick comment, but forgot to add 'nit'. Nothing is wrong here, only the name doesn't really fit. And I think it also doesn't really fit for renameManagedKuduTable() (but no need to change it there). My suggestion was only to rename the variable to 'msTbl'. I'm also OK with keeping the original name, I just noticed that there was no reply to this comment. -- To view, visit http://gerrit.cloudera.org:8080/16606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5104cc47c7b42dacdb52983f503cd263135d6bfc Gerrit-Change-Number: 16606 Gerrit-PatchSet: 6 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 15:00:12 +0000 Gerrit-HasComments: Yes
