Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. ...................................................................... IMPALA-10244: Make non-scalable failures to dequeue observable. One of the important ways to observe Impala throughput is by looking at when queries are queued. This can be an indication that more resources should be added to the cluster by adding more executor groups. This is only a good strategy if adding more resources will help with the current workload. In some situations the head of the query queue cannot be executed because of resource constraints on the coordinator. In these cases the coordinator is the bottleneck so adding more executor groups will not help. This change is to make these cases observable by adding a new counter which is incremented when a dequeue fails because of resource constraints on the coordinator. The two cases that cause the counter to be incremented are: - when there are not enough admission control slots on the coordinator - when there is not enough memory on the coordinator but it is possible that other conditions may be added in future. TESTING: Added new unit tests. Ran all end-to-end tests. Change-Id: I3456396ac139c562ad9cd3ac1a624d8f35487518 Reviewed-on: http://gerrit.cloudera.org:8080/16613 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/scheduling/admission-controller-test.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M common/thrift/metrics.json M tests/custom_cluster/test_admission_controller.py 5 files changed, 161 insertions(+), 55 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3456396ac139c562ad9cd3ac1a624d8f35487518 Gerrit-Change-Number: 16613 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
