Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16545 )
Change subject: IMPALA-10215: Implement INSERT INTO for non-partitioned Iceberg tables (Parquet) ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16545/7/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java: http://gerrit.cloudera.org:8080/#/c/16545/7/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java@81 PS7, Line 81: Exception Catching every exception is potentially an overkill, as it may hide bugs that we should actually investigate. Was this added to catch CannotObtainBlockLengthException ( based on https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/3374/testReport/stress.test_insert_stress/TestInsertStress/test_iceberg_inserts_unique_database0_/ )? -- To view, visit http://gerrit.cloudera.org:8080/16545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5690fb6c2cc51f0033fa26caf8597c80a11bcd8e Gerrit-Change-Number: 16545 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Mon, 26 Oct 2020 08:17:39 +0000 Gerrit-HasComments: Yes
