Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 )
Change subject: IMPALA-10252: fix invalid runtime filters for outer joins ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16622/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16622/4//COMMIT_MSG@17 PS4, Line 17: x = isnull(y, 1) can return true even if y is NULL. > https://cwiki.apache.org/confluence/display/IMPALA/Impala+Row+Batches descr Okay. The tuple level nullability indicator in the plan is very helpful. I like it a lot. For this special case when prepare the filter for a join predicate non null-rejecting, I guess we need an extra step to compute the filter value for a null row from the inner due to the outer join. This is almost like we need to an expression on top of 4 to expand tuple 1 to 1N, where N is for the null row described above. The expression probably can take care of the descriptor clone. Anyway, I am very fine with the current fix. -- To view, visit http://gerrit.cloudera.org:8080/16622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507af1cc8df15bca21e0d8555019997812087261 Gerrit-Change-Number: 16622 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Oct 2020 17:46:43 +0000 Gerrit-HasComments: Yes
