Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16671 )
Change subject: IMPALA-10298: Change column mask hash as SHA512 in FIPS mode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16671/1/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16671/1/be/src/exprs/mask-functions-ir.cc@708 PS1, Line 708: if (FIPS_mode()) { Any reason not to just use SHA512 in non-fips mode too? -- To view, visit http://gerrit.cloudera.org:8080/16671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I422d4b11b31c3e6eb7963260a1da730579c4ca74 Gerrit-Change-Number: 16671 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Oct 2020 18:40:37 +0000 Gerrit-HasComments: Yes
