Fucun Chu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16626 )

Change subject: IMPALA-10132: Implement ds_hll_estimate_bounds_as_string() 
function.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@10
PS4, Line 10:
> nit: please remove the trailing spaces
Done


http://gerrit.cloudera.org:8080/#/c/16626/4//COMMIT_MSG@11
PS4, Line 11: returns
> nit: start with capital letter
Done



--
To view, visit http://gerrit.cloudera.org:8080/16626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46bf8263e8fd3877a087b9cb6f0d1a2392bb9153
Gerrit-Change-Number: 16626
Gerrit-PatchSet: 4
Gerrit-Owner: Fucun Chu <chufu...@hotmail.com>
Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2020 08:58:48 +0000
Gerrit-HasComments: Yes

Reply via email to