Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16630 )
Change subject: IMPALA-10206: Avoid MD5 Digest Authorization in FIPS approved mode ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16630/6/be/src/util/webserver-test.cc File be/src/util/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/16630/6/be/src/util/webserver-test.cc@439 PS6, Line 439: if (FIPS_mode()) return; Once we're returning an error status (per my other comment), lets have this test check for that, ie. do an if(FIPS_mode()) ASSERT_ERROR(webserver.Start()) http://gerrit.cloudera.org:8080/#/c/16630/6/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16630/6/be/src/util/webserver.cc@401 PS6, Line 401: LOG(WARNING) << "HTTP digest authorization is not supported in FIPS approved mode."; We should probably return an error status here, just to be sure people don't accidentally misconfigure this. -- To view, visit http://gerrit.cloudera.org:8080/16630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie075389b3ab65c612d64ba58e16a10b19bdf4d6f Gerrit-Change-Number: 16630 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 29 Oct 2020 20:47:49 +0000 Gerrit-HasComments: Yes
