Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16689 )
Change subject: IMPALA-10306: [DOCS] add note about TZ offset ...................................................................... Patch Set 1: (3 comments) Thanks for the review Gabor, I have overlooked some part of the documentation and misunderstood this change. I commented the parts of the documentation that refer to non-existing functionalities, these could be removed. Gabor's explanation could be part of the bulletpoints in the middle I think. http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1323 PS1, Line 1323: <row> : <entry> : <codeph>+/-hh:mm</codeph> : </entry> : <entry> : Time zone offset : </entry> : </row> : <row> : <entry> : <codeph>+/-hhmm</codeph> : </entry> : <entry> : Time zone offset : </entry> : </row> : <row> : <entry> : <codeph>+/-hh</codeph> : </entry> : <entry> : Time zone offset : </entry> : </row> These formatting options will be disregarded. http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1370 PS1, Line 1370: except for the time zone offset The formatting of this timezone offset is not relevant here. http://gerrit.cloudera.org:8080/#/c/16689/1/docs/topics/impala_datetime_functions.xml@1384 PS1, Line 1384: <li> : <codeph>yyyy-MM-dd HH:mm:ss+hh:mm</codeph> : </li> This part explains how to use the timezone offset, which can not be applied here. -- To view, visit http://gerrit.cloudera.org:8080/16689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I693d15f1230dd7eebcbf2a16657a3850943749e1 Gerrit-Change-Number: 16689 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Nov 2020 08:15:05 +0000 Gerrit-HasComments: Yes
