Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16712 )
Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16712/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/16712/3/tests/common/impala_test_suite.py@933 PS3, Line 933: # Both a and b must be positive for the following check to make sense. > I think I will fix appx_equals for -ive values like you suggested. I changed the diff_perc in test_stats_extrapolation to 1.0 from 2.0. For very small sampling percentage like 1 or 3 we do get a large variance between extrapolated #rows and actual #rows. The condition we are trying to catch is any time we have a -1 (which indicates stats not set). appx_equals(X, -1, 1.0) returns false since X+1/X > 1.0 The test case passes with 1.0. We are now also ensuring that the extrapolated #rows >= 0 in the testcase. So we should be covered as far as catching this issue through the test. -- To view, visit http://gerrit.cloudera.org:8080/16712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a0a777c2be9cc18b3ff293cf1c06fb499ca052 Gerrit-Change-Number: 16712 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Nov 2020 02:11:21 +0000 Gerrit-HasComments: Yes
