Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16723 )

Change subject: IMPALA-10314: Optimize planning time for simple limits
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@847
PS1, Line 847:         
(analyzer.getQueryCtx().client_request.getQuery_options().isOptimize_simple_limit()
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1328
PS1, Line 1328:       inlineViewRef.getAnalyzer().setSimpleLimitStatus(new 
Pair<>(new Boolean(true), outerStatus.second));
line too long (106 > 90)


http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1564
PS1, Line 1564:           && 
analyzer.getQueryCtx().client_request.getQuery_options().isOptimize_simple_limit()
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1581
PS1, Line 1581:         scanNode = new HdfsScanNode(ctx_.getNextNodeId(), 
tupleDesc, conjuncts, finalPartitions,
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1584
PS1, Line 1584:         scanNode = new HdfsScanNode(ctx_.getNextNodeId(), 
tupleDesc, conjuncts, partitions,
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/16723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d6a79263bc092e0f3e9a1d72da5618f3cc35574
Gerrit-Change-Number: 16723
Gerrit-PatchSet: 1
Gerrit-Owner: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Sun, 15 Nov 2020 01:45:48 +0000
Gerrit-HasComments: Yes

Reply via email to