Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16719 )
Change subject: IMPALA-10323: use snprintf instead of lexical_cast to cast to string ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16719/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16719/1//COMMIT_MSG@10 PS1, Line 10: performance can be improved significantly in : multi-thread mode(mt_dop mode). In contrast, performance using : lexical_cast decreased seriously in multi-thread mode. Do you have any measurements to see what is the order of magnitude of this increase in performance? Even if it's taken on a PC it's worth including here in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/16719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief1d6b2c2cb5961c1d6cee1b0eac86ab61509768 Gerrit-Change-Number: 16719 Gerrit-PatchSet: 1 Gerrit-Owner: wesleydeng <wesleyd...@tencent.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: abeltian <abelt...@tencent.com> Gerrit-Comment-Date: Mon, 16 Nov 2020 13:47:11 +0000 Gerrit-HasComments: Yes
