Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 )
Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ...................................................................... Patch Set 15: Code-Review+2 (4 comments) Thanks for the patience, this looks good to me. Good to see the new tests and cleanup. Couple minor points, but I'm going to go ahead and +2. http://gerrit.cloudera.org:8080/#/c/16057/15/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/16057/15/be/src/util/runtime-profile-test.cc@562 PS15, Line 562: for (int i = 0; i < offset + NUM_PROFILES; ++i) { : if (i < offset || i >= offset + NUM_PROFILES) { : EXPECT_FALSE(tcounter.has_value[i]); : continue; : } Due to the loop condition, i < offset + NUM_PROFILES, so it won't test the i >= offset + NUM_PROFILES part. For the case of the AggregatedRuntimeProfile with 5 entries, it will test the first four. We probably need to detect the total size to be able to iterate over the whole thing. I like that this is testing the entries that are not supposed to be set. http://gerrit.cloudera.org:8080/#/c/16057/15/be/src/util/runtime-profile-test.cc@771 PS15, Line 771: static void VerifyThriftInfoStrings( Nit: It would be nice to verify that the entries outside of offset, offset + NUM_PROFILES are not touched like we do in VerifyThriftSummaryStats(). http://gerrit.cloudera.org:8080/#/c/16057/15/be/src/util/runtime-profile-test.cc@962 PS15, Line 962: static void VerifyThriftEventSequences( Nit: It would be nice to verify that the entries outside of offset, offset + NUM_PROFILES are not touched like we do in VerifyThriftSummaryStats(). http://gerrit.cloudera.org:8080/#/c/16057/15/be/src/util/runtime-profile-test.cc@1374 PS15, Line 1374: static void VerifyThriftTimeSeries( Nit: It would be nice to verify that the entries outside of offset, offset + NUM_PROFILES are not touched like we do in VerifyThriftSummaryStats(). -- To view, visit http://gerrit.cloudera.org:8080/16057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic680cbfe94c939c2a8fad9d0943034ed058c6bca Gerrit-Change-Number: 16057 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Nov 2020 18:00:23 +0000 Gerrit-HasComments: Yes
