Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 )
Change subject: IMPALA-10314: Optimize planning time for simple limits ...................................................................... Patch Set 12: > Uploaded patch set 12. Additional testing found a bug that when the WHERE clause hint was within a view, it was not being recognized by the simple limit optimization. The reason was the SQL generation was not propagating this additional hint and HMS definition for the view did not have the hint. PS 12 fixes this. I have done manual testing with such views. However, I haven't been able to add a test with a hint in a view. I tried creating a view with hints in the functional_schema_template.sql and the view was created but doing a 'DESCRIBE EXTENDED' shows hint was missing. This needs further exploration on the test infrastructure. -- To view, visit http://gerrit.cloudera.org:8080/16723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6a79263bc092e0f3e9a1d72da5618f3cc35574 Gerrit-Change-Number: 16723 Gerrit-PatchSet: 12 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Nov 2020 00:33:39 +0000 Gerrit-HasComments: No
