Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16788 )

Change subject: IMPALA-10361: Use field id to resolve columns for Iceberg tables
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

Thanks for adding the tests, the change looks great. I'm planning to do another 
round next week, so only giving it +1 for now.

I think for Iceberg tables we should always try to resolve columns via field 
id, i.e. for Iceberg tables we can ignore the value of 
PARQUET_FALLBACK_SCHEMA_RESOLUTION.

Do you plan to implement this for ORC tables as well (in a separate patch)? 
Maybe we should open another Jira/subtask for that.

http://gerrit.cloudera.org:8080/#/c/16788/5/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java:

http://gerrit.cloudera.org:8080/#/c/16788/5/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@339
PS5, Line 339:         boolean isFullAcidTable = 
AcidUtils.isFullAcidTable(msTbl.getParameters());
Iceberg tables cannot be full ACID, maybe it can be a precondition.


http://gerrit.cloudera.org:8080/#/c/16788/5/testdata/data/README
File testdata/data/README:

http://gerrit.cloudera.org:8080/#/c/16788/5/testdata/data/README@608
PS5, Line 608: generated file will contains multi blocks, multi pages per block.
Please add information about the newly added files and tests.



--
To view, visit http://gerrit.cloudera.org:8080/16788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I057bdc6ab2859cc4d40de5ed428d0c20028b8435
Gerrit-Change-Number: 16788
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sky...@163.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: wangsheng <sky...@163.com>
Gerrit-Comment-Date: Fri, 04 Dec 2020 13:19:05 +0000
Gerrit-HasComments: Yes

Reply via email to