Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16821 )
Change subject: IMPALA-9865: part 1: basic profile log parser ...................................................................... Patch Set 2: (2 comments) > Uploaded patch set 2. Hi Tim, Thanks for writing this parser. This is very useful. I just have 2 comment. http://gerrit.cloudera.org:8080/#/c/16821/2/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/16821/2/be/src/util/impala-profile-tool.cc@31 PS2, Line 31: // is pretty-printed to standard output. Add simple usage example in the doc maybe? like impala-profile-tool < impala_profile_log_1.1-1607057366897 http://gerrit.cloudera.org:8080/#/c/16821/2/be/src/util/impala-profile-tool.cc@59 PS2, Line 59: getline(cin, line); Tried to run the parser against my local runtime profile log. It seems It always hit "Error reading line" when it reach EOF. What if we move this getline as the loop condition? say for (std::string line; std::getline(cin, line); ) { -- To view, visit http://gerrit.cloudera.org:8080/16821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6178399addddc96e176f7067cc47347e51cda2f3 Gerrit-Change-Number: 16821 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 05 Dec 2020 02:48:40 +0000 Gerrit-HasComments: Yes
