Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16792 )

Change subject: IMPALA-10360: Allow simple limit to be treated as sampling hint
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java
File fe/src/main/java/org/apache/impala/analysis/TableRef.java:

http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java@268
PS7, Line 268:   public boolean hasConvertLimitToSampleHint() { return 
convertLimitToSampleHintPercent_ != -1; }
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java@269
PS7, Line 269:   public int getConvertLimitToSampleHintPercent() { return 
convertLimitToSampleHintPercent_; }
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/16792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05a5343c913006f7659949b327b63d3f10c04b
Gerrit-Change-Number: 16792
Gerrit-PatchSet: 7
Gerrit-Owner: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Dec 2020 22:56:20 +0000
Gerrit-HasComments: Yes

Reply via email to