Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16847 )
Change subject: IMPALA-10066: Fix test_cancellation_mid_command flakiness ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Thanks for taking care of this! Great work! I found some nits but other than them the patch seems fine for me. http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@9 PS1, Line 9: to to nit: typo http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@9 PS1, Line 9: syncronisation nit: synchronisation http://gerrit.cloudera.org:8080/#/c/16847/1//COMMIT_MSG@14 PS1, Line 14: without nit: without this fix -- To view, visit http://gerrit.cloudera.org:8080/16847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief384ce59f3ce24f1ab2dfb5fbaf7c9a39b434e0 Gerrit-Change-Number: 16847 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Dec 2020 07:46:50 +0000 Gerrit-HasComments: Yes