Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16851 )
Change subject: IMPALA-10358: Correct Iceberg type mappings ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16851/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16851/1//COMMIT_MSG@13 PS1, Line 13: * annotates strings with UTF8 in Parquet metadata These changes make sense to me. I did add a TYPE_FIXED_UDA_INTERMEDIATE type internally that has the same semantics as FIXED, i.e. essentially the BINARY variant of CHAR, so that could maybe be something that is extended in future to be a user-visible type. I'm curious how timestamptz works now - do we just treat it as an Impala TIMESTAMP and rely on the Parquet reader to convert when reading? I guess we can't write it if there's a timestamptz column in an Iceberg table? -- To view, visit http://gerrit.cloudera.org:8080/16851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652565f82708824f5cf7497139153b06f116ccd3 Gerrit-Change-Number: 16851 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 10 Dec 2020 20:21:06 +0000 Gerrit-HasComments: Yes
