Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16869 )
Change subject: IMPALA-9922: A better approach to deal with date's sub-second fractions ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/datetime-simple-date-format-parser.cc File be/src/runtime/datetime-simple-date-format-parser.cc: http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/datetime-simple-date-format-parser.cc@475 PS2, Line 475: if (!ParseFractionToken(tok_val, tok_len, fraction_desired_len, dt_result)) return false; line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/timestamp-test.cc@629 PS2, Line 629: (TimestampTC("yyyy-MM-dd HH:mm:ss:SSS", "2020-10-01 10:54:00:13", false, true, true, 2020, 10, 1, 10, 54, 0, 13000000)) line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/timestamp-test.cc@631 PS2, Line 631: (TimestampTC("yyyy-MM-dd HH:mm:ss:SSS", "2020-10-01 10:54:00:1345",false, true, true, 2020, 10, 1, 10, 54, 0, 134000000)) line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/timestamp-test.cc@633 PS2, Line 633: (TimestampTC("yyyy-MM-dd HH:mm:ss:SSS", "2020-10-01 10:54:00:134",false, true, true, 2020, 10, 1, 10, 54, 0, 134000000)) line too long (124 > 90) http://gerrit.cloudera.org:8080/#/c/16869/2/be/src/runtime/timestamp-test.cc@635 PS2, Line 635: (TimestampTC("yyyy-MM-dd HH:mm:ss:S", "2020-10-01 10:54:00:1345",false, true, true, 2020, 10, 1, 10, 54, 0, 134500000)) line too long (123 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e870bb8ad8fd14d388f37dfc5175589ecf9a5a7 Gerrit-Change-Number: 16869 Gerrit-PatchSet: 2 Gerrit-Owner: fifteencai <fifteen...@tencent.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Dec 2020 01:30:27 +0000 Gerrit-HasComments: Yes
