Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 )
Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions ...................................................................... Patch Set 14: Code-Review+2 (3 comments) I've left some minor comments, but the change looks great overall! http://gerrit.cloudera.org:8080/#/c/16741/14/be/src/exprs/iceberg-functions-ir.cc File be/src/exprs/iceberg-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16741/14/be/src/exprs/iceberg-functions-ir.cc@75 PS14, Line 75: return TruncatePartitionTransformDecimalImpl<int32_t>(input.val4, width.val); TruncatePartitionTransformNumericImpl handles negative overflow, i.e. when input.val < 0 && result.val >= 0. I think we should do it here is as well. http://gerrit.cloudera.org:8080/#/c/16741/14/be/src/exprs/iceberg-functions-ir.cc@163 PS14, Line 163: c_str nit: it doesn't really make a difference, but buffer.data() could be used instead which maybe expresses the intent better http://gerrit.cloudera.org:8080/#/c/16741/14/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/16741/14/be/src/util/bit-util.h@363 PS14, Line 363: buffer.append(&value_to_save, 1); nit: string also has push_back member function, so this could be just buffer.push_back(value_to_save); -- To view, visit http://gerrit.cloudera.org:8080/16741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I485680cf79d96d578dd8cfbfd554bec468fe84bd Gerrit-Change-Number: 16741 Gerrit-PatchSet: 14 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Dec 2020 17:34:43 +0000 Gerrit-HasComments: Yes
