Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16861 )
Change subject: IMPALA-10388: [DOCS] add limitations on mask functions ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16861/1/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: http://gerrit.cloudera.org:8080/#/c/16861/1/docs/topics/impala_authorization.xml@693 PS1, Line 693: <p>Changes in Hive UDF implemented through "GenericUDF" supports mask functions. Even though : Impala users can call Hive UDFs, Impala does not yet support new Hive UDFs based on the : GenericUDF class. Due to the lack of a corresponding framework for GenericUDF in Impala, : this release introduced some of these mask functions through overloads.</p> The first sentense make me confused. The GenericUDF framework and the mask functions in Hive have been implemented for years. Not sure what "Changes" means. I think this explains the limitation better: <p>The mask functions in Hive are GenericUDFs. However, Impala currently doesn't support Hive GenericUDFs, so you can't use Hive's mask functions in Impala. Impala has builtin mask functions. They are implemented by overloads. Thus, when using mask functions, not all parameter combinations are supported in Impala.</p> I'm not a native English speaker. Please help to correct the grammar mistakes and polish the content. :) http://gerrit.cloudera.org:8080/#/c/16861/1/docs/topics/impala_authorization.xml@697 PS1, Line 697: <p>The following list includes all the overloads that are introduced in this release.</p> This is not a release doc, but a doc that will be used in all releases. I don't think we should mentione "in this release" here. BTW, the mask functions are added in Impala-3.4, not the comming release version (4.0). Can you update this too: <p>The following list includes all the overloads that are implemented.</p> http://gerrit.cloudera.org:8080/#/c/16861/1/docs/topics/impala_authorization.xml@710 PS1, Line 710: <li>The function mask(FLOAT) is not implemented in Impala. Do not use Redact(MASK) on : float/double/decimal types as Hive always returns NULL for them since it is not redact. : You can use a more efficient Nullify policy (MASK_NULL) for the same purpose.</li> This is just an example explaining the overload, mask(FLOAT), is currently missing in Impala. And then provides a work around. I think we can update this paragraph to <li>As an example, the function mask(FLOAT) is currently not implemented in Impala. Do not use Redact(MASK) on float/double/decimal types as Hive always returns NULL for them so it is not redact actually. If you do want to mask float/double/decimal to NULLs, you can use a more efficient Nullify policy (MASK_NULL) for the same purpose.</li> -- To view, visit http://gerrit.cloudera.org:8080/16861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37f0bcf4cf586cc5cfd03e4df68443967b6bb88f Gerrit-Change-Number: 16861 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 17 Dec 2020 07:32:42 +0000 Gerrit-HasComments: Yes
