Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16837 )
Change subject: IMPALA-10211 (Part 1): Add support for role-related statements ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Thanks for creating the Ranger tickets! http://gerrit.cloudera.org:8080/#/c/16837/7/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: http://gerrit.cloudera.org:8080/#/c/16837/7/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test@1273 PS7, Line 1273: ==== : ---- USER : admin : ---- QUERY : # Clean up the granted privileges and test roles. : # Note that we need to revoke those previously granted privileges so that each role is : # not referenced by any policy before we delete those roles. : # Moreover, we need to revoke the privilege on the database 'grant_rev_db' before : # dropping 'grant_rev_db'. Otherwise, the revocation would fail due to an : # AnalysisException thrown because 'grant_rev_db' does not exist. : revoke all on server from grant_revoke_test_ALL_SERVER; : revoke all on uri '$FILESYSTEM_PREFIX/test-warehouse/grant_rev_test_tbl2' from grant_revoke_test_ALL_URI; : revoke all on uri '$FILESYSTEM_PREFIX/test-warehouse/GRANT_REV_TEST_TBL3' from grant_revoke_test_ALL_URI; : revoke all on uri '$FILESYSTEM_PREFIX/test-warehouse/grant_rev_test_prt' from grant_revoke_test_ALL_URI; : revoke all on database functional from grant_revoke_test_NON_OWNER; : drop role grant_revoke_test_ALL_SERVER; : drop role grant_revoke_test_SELECT_INSERT_TEST_TBL; : drop role grant_revoke_test_ALL_URI; : drop role grant_revoke_test_NON_OWNER; : drop role grant_revoke_test_ALL_SERVER1; : drop role grant_revoke_test_COLUMN_PRIV; : ---- RESULTS : 'Role has been dropped.' : ==== These are no longer needed, right? Or for clarity you want to clean these up both here and in the .py file? -- To view, visit http://gerrit.cloudera.org:8080/16837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b204e62a1d8ae1932d955b4efc28be22202860 Gerrit-Change-Number: 16837 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 17 Dec 2020 15:51:01 +0000 Gerrit-HasComments: Yes
