Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16706 )
Change subject: IMPALA-10317: Add query option that limits huge joins at runtime ...................................................................... Patch Set 5: (3 comments) Looking good. Just couple of minor comments. http://gerrit.cloudera.org:8080/#/c/16706/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16706/5//COMMIT_MSG@9 PS5, Line 9: Join node You may want to mention why it is useful even though it may be somewhat obvious. Something like '..produced by a join node such that runaway join queries can be prevented.' http://gerrit.cloudera.org:8080/#/c/16706/3/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/16706/3/be/src/runtime/coordinator.h@230 PS3, Line 230: /// Total num rows produced by each join node. The key is join node id. > The key has been changed to node id Good ! http://gerrit.cloudera.org:8080/#/c/16706/5/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/16706/5/common/protobuf/control_service.proto@261 PS5, Line 261: map<int32, int64> per_join_rows_produced = 16; Mark this as 'optional' field ? -- To view, visit http://gerrit.cloudera.org:8080/16706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbca7e053b61b4e31b066edcfb3b0398fa859d02 Gerrit-Change-Number: 16706 Gerrit-PatchSet: 5 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Dec 2020 07:53:47 +0000 Gerrit-HasComments: Yes
