Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 )
Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/16881/7/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/16881/7/be/src/util/runtime-profile.cc@2723 PS7, Line 2723: if (verbosity <= Verbosity::LEGACY) continue; > Looks like this condition can be flipped and merged with the branch bellow? Done http://gerrit.cloudera.org:8080/#/c/16881/6/tests/observability/test_profile_tool.py File tests/observability/test_profile_tool.py: http://gerrit.cloudera.org:8080/#/c/16881/6/tests/observability/test_profile_tool.py@36 PS6, Line 36: self._compare_profile_tool_output([], > Ok, I understand the difference now. Setting --profile_verbosity=legacy mea Yeah, producing identical output is not necessarily the goal of this tool, but we do want to be able to parse older profiles and we want to have some tests for pretty-printing so that it's rendered as expected. One thing I'm hoping to achieve with the tool is to buy more flexibility around the text representation of the V2 profiles. We had a lot of dilemmas about how much information to include, but those are less important if we can print the profile with more/less information later on; or if we can improve the output in the tool independent of the version of Impala profiles being analyzed. -- To view, visit http://gerrit.cloudera.org:8080/16881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82618a813e29af7996dfaed78873b2a73bc0231d Gerrit-Change-Number: 16881 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Dec 2020 06:33:10 +0000 Gerrit-HasComments: Yes