Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 )
Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate ...................................................................... Patch Set 42: (4 comments) http://gerrit.cloudera.org:8080/#/c/16720/42/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/16720/42/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@757 PS42, Line 757: options.setDisable_overlap_filter(true); // Required so that output doesn't vary by whether parquet tables are used or not. line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/16720/42/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@787 PS42, Line 787: options.setDisable_overlap_filter(true); // Required so that output doesn't vary by the format of the table used. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/42/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@787 PS42, Line 787: options.setDisable_overlap_filter(true); // Required so that output doesn't vary by the format of the table used. line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/16720/42/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/16720/42/tests/run-tests.py@219 PS42, Line 219: % flake8: E131 continuation line unaligned for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/16720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I379405ee75b14929df7d6b5d20dabc6f51375691 Gerrit-Change-Number: 16720 Gerrit-PatchSet: 42 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sun, 27 Dec 2020 05:28:09 +0000 Gerrit-HasComments: Yes