Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 2: (1 comment) Thanks for catching up this! http://gerrit.cloudera.org:8080/#/c/16911/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16911/2//COMMIT_MSG@25 PS2, Line 25: Testing: Could you add some test coverage in tests/custom_cluster/test_query_retries.py? We may need to extend test_retry_query_cancel or add some new tests similar to it. -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 31 Dec 2020 00:46:42 +0000 Gerrit-HasComments: Yes
