Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 )
Change subject: IMPALA-10377 Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16842/3/testdata/workloads/functional-planner/queries/PlannerTest/topn-bytes-limit.test File testdata/workloads/functional-planner/queries/PlannerTest/topn-bytes-limit.test: http://gerrit.cloudera.org:8080/#/c/16842/3/testdata/workloads/functional-planner/queries/PlannerTest/topn-bytes-limit.test@11 PS3, Line 11: HDFS partitions=4/4 files=4 size=460B Thanks for your patch. Since there was no meaningful change in resource estimates in these tests (and several other files like this), would you mind creating the patch without the superficial changes (the 'HDFS' string is unfortunately added .. not because of your changes). It would reduce the noise and help the review process. For the test files that contain any relevant change (in the HashJoin, Sort etc.) you can leave the HDFS change as-is since those files are anyways getting modified. -- To view, visit http://gerrit.cloudera.org:8080/16842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01db168ff2c6d6de33ee553a8175599f035d7a1 Gerrit-Change-Number: 16842 Gerrit-PatchSet: 3 Gerrit-Owner: liuyao <liu...@sensorsdata.cn> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: liuyao <liu...@sensorsdata.cn> Gerrit-Comment-Date: Mon, 04 Jan 2021 00:20:14 +0000 Gerrit-HasComments: Yes
