Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16917 )
Change subject: IMPALA-10182: Don't add inferred identity predicates to SELECT node ...................................................................... Patch Set 2: > Patch Set 2: > > > Patch Set 1: Code-Review+1 > > > > Thanks for taking care of this bug! > > > > This fixes IMPALA-9694 as well. Could you also add some test cases for > > IMPALA-9694? > > Thanks for the quick review. I have added a test case for this. BTW, as I noted in the test comments, IMPALA-9694 query has an analytic function but it will not show up in the final plan. I tried a couple of variants where it could show up in the plan but those don't throw the original exception. If you have any other failing example, let me know. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/16917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924044f582652dbc50085851cc639f3dee1cd1f4 Gerrit-Change-Number: 16917 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 04 Jan 2021 19:30:48 +0000 Gerrit-HasComments: No
