Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16893 )
Change subject: IMPALA-6434: Add support to decode RLE_DICTIONARY encoded pages ...................................................................... Patch Set 4: Code-Review+2 (1 comment) An 'if' statement might be redundant, but other than that LGTM. http://gerrit.cloudera.org:8080/#/c/16893/4/be/src/exec/parquet/hdfs-parquet-table-writer.cc File be/src/exec/parquet/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/16893/4/be/src/exec/parquet/hdfs-parquet-table-writer.cc@893 PS4, Line 893: if (IsDictionaryEncoding(current_encoding_) : && FLAGS_write_new_parquet_dictionary_encodings) { : header.data_page_header.encoding = parquet::Encoding::RLE_DICTIONARY; : } Is this 'if' statement still needed? Now that we use 'DataPageDictionaryEncoding()' to set current_encoding_. -- To view, visit http://gerrit.cloudera.org:8080/16893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90942022edcd5d96c720a1bde53879e50394660a Gerrit-Change-Number: 16893 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Jan 2021 10:36:37 +0000 Gerrit-HasComments: Yes
