Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 )
Change subject: IMPALA-9979: part 2: partitioned top-n ...................................................................... Patch Set 21: (4 comments) http://gerrit.cloudera.org:8080/#/c/16242/21/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/16242/21/be/src/exec/topn-node.cc@58 PS21, Line 58: DEFINE_int64(partitioned_topn_soft_limit_bytes, 64L * 1024L * 1024L, "(Experimental) Soft " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16242/21/be/src/exec/topn-node.cc@246 PS21, Line 246: // Each tuple_row_less_than_->Less(Tuple*, Tuple*) indirectly calls Compare() once. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16242/21/be/src/exec/topn-node.cc@254 PS21, Line 254: // Each tuple_row_less_than_->Less(Tuple*, Tuple*) indirectly calls Compare() once. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16242/21/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/16242/21/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@1177 PS21, Line 1177: childSortNode.getSortInfo(), offset, limit, childSortNode.isIncludeTies()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic638af9495981d889a4cb7455a71e8be0eb1a8e5 Gerrit-Change-Number: 16242 Gerrit-PatchSet: 21 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Jan 2021 01:03:43 +0000 Gerrit-HasComments: Yes
