Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 )
Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate ...................................................................... Patch Set 46: (5 comments) http://gerrit.cloudera.org:8080/#/c/16720/46/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16720/46/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@312 PS46, Line 312: OverlapPredicate Instead of having this class, maybe we could just use TOverlapPredicate directly. http://gerrit.cloudera.org:8080/#/c/16720/46/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@338 PS46, Line 338: pageOverlapTuple_ Seems like it's unused. http://gerrit.cloudera.org:8080/#/c/16720/46/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/16720/46/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@601 PS46, Line 601: overlap-filter nit: seems like the terms "minmax-filter" and "overlap predicate" are being mixed at couple of places. Maybe it'd be worth to iron it out, and either use "minmax-filter" or "overlap-predicate" at all places. http://gerrit.cloudera.org:8080/#/c/16720/46/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test: http://gerrit.cloudera.org:8080/#/c/16720/46/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@26 PS46, Line 26: OVERLAP_FILTER nit: maybe we should name it DISABLE_MINMAX_FILTER? http://gerrit.cloudera.org:8080/#/c/16720/46/testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test@44 PS46, Line 44: interferece nit: typo, interference -- To view, visit http://gerrit.cloudera.org:8080/16720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I379405ee75b14929df7d6b5d20dabc6f51375691 Gerrit-Change-Number: 16720 Gerrit-PatchSet: 46 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Jan 2021 16:37:46 +0000 Gerrit-HasComments: Yes
