Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 )
Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions ...................................................................... Patch Set 10: (3 comments) Thanks! Added more info in the commit message and comments. http://gerrit.cloudera.org:8080/#/c/16908/9/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/16908/9/be/src/exprs/expr-test.cc@10542 PS9, Line 10542: TEST_P(ExprTest, Utf8Test) { > Some of the characters below are > 2 bytes right? It would be helpful to ad Done. http://gerrit.cloudera.org:8080/#/c/16908/9/be/src/exprs/expr-test.cc@10596 PS9, Line 10596: TestStringValue("utf8_reverse('')", ""); > Can we add tests for a couple of grapheme clusters where we're reversing th Done http://gerrit.cloudera.org:8080/#/c/16908/9/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16908/9/be/src/exprs/string-functions-ir.cc@496 PS9, Line 496: // Returns a string with the UTF-8 characters (code points) in revrese order. Note that > Comment that this reverses codepoints only, and that's consistent with othe Done -- To view, visit http://gerrit.cloudera.org:8080/16908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0aaf3544e89f8a3d531ad6afe056b3658b525b7c Gerrit-Change-Number: 16908 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Jan 2021 03:11:09 +0000 Gerrit-HasComments: Yes
